feat(constants): render atom-disagg as Mooncake ATOM framework#443
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 35789e4. Configure here.
| * Single source of truth — consumed by ETL, frontend, and changelog processing. | ||
| */ | ||
| export const FRAMEWORK_ALIASES: Record<string, { canonical: string; disagg?: boolean }> = { | ||
| 'atom-disagg': { canonical: 'mooncake-atom', disagg: true }, |
There was a problem hiding this comment.
Mooncake atom skips disagg forcing
Medium Severity
This change introduces canonical mooncake-atom for disaggregated Mooncake ATOM runs, but ETL normalizeFramework only forces disagg for dynamo-* and mori-* canonical names. Rows ingested with framework already set to mooncake-atom and disagg false can keep disagg: false, unlike other disagg-only frameworks.
Reviewed by Cursor Bugbot for commit 35789e4. Configure here.
1 participant
Note
Low Risk
Small constants-only change with tests; ETL and UI pick up aliases automatically with no auth or data-schema changes.
Overview
Adds
mooncake-atomto the shared framework registry with display label Mooncake ATOM¹, and maps the legacyatom-disaggidentifier to that canonical key withdisagg: trueinFRAMEWORK_ALIASES(same pattern assglang-disagg→mori-sglang).Because ETL
normalizeFrameworkand UI label resolution already read these constants,atom-disaggin artifacts and config keys (e.g.dsv4-fp4-mi355x-atom-disagg) now normalize tomooncake-atomand show as Mooncake ATOM¹. Coverage is extended inframework-aliasesand ETL normalizer tests.Reviewed by Cursor Bugbot for commit 35789e4. Bugbot is set up for automated code reviews on this repo. Configure here.